Yes, that is the right electrical type, but the shaft is a 'solid with a flat bit taken out', which is common on electronics, and uncommon on guitars / basses. Sometimes important to look at that if you want the same knobs
I would also only have a make before break in a guitar wiring application if I had a choice, to avoid massive pop noises. It doesn't matter if you short two coils together or one to ground, as long as you don't disconnect and reconnect. However, I suspect you have little choice in options