^^ this
Knowing the scale / mode, how to play it and how it is constructed is important but what I have learnt the frustrating way is that unless you can apply it musically it has no value.
I'm changing my approach to learning sclaes & modes by 1, doing some circle of fifth, two octave and chord tones over chord progression exercises mixed with a big chunk of time just jamming to backing tracks / songs with those scales and getting a feel wmcof what sounds good.
The latter part is what is improving me as a player